Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update golden test zrealm_tests0_stdlibs.gno #2524

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR is a hotfix for gnovm/tests/files/zrealm_tests0_stdlibs.gno, and updates the golden tests accordingly

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos requested a review from moul July 6, 2024 15:43
@zivkovicmilos zivkovicmilos self-assigned this Jul 6, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 6, 2024
@petar-dambovaliev petar-dambovaliev self-requested a review July 6, 2024 15:55
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zivkovicmilos zivkovicmilos merged commit a825344 into master Jul 6, 2024
14 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/hotfix-golden branch July 6, 2024 15:57
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
## Description

This PR is a hotfix for `gnovm/tests/files/zrealm_tests0_stdlibs.gno`,
and updates the golden tests accordingly

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants