Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/grc20reg #2516

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

feat: add r/grc20reg #2516

wants to merge 71 commits into from

Conversation

moul
Copy link
Member

@moul moul commented Jul 5, 2024

Continues #1072
Related #1275, #1262
Depends on #1257
Depends on #2551

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 5, 2024
@moul moul mentioned this pull request Jul 5, 2024
7 tasks
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (9897b66) to head (aaa5922).

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/machine.go 63.15% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2516      +/-   ##
==========================================
- Coverage   60.87%   58.81%   -2.06%     
==========================================
  Files         563      560       -3     
  Lines       75193    74731     -462     
==========================================
- Hits        45770    43955    -1815     
- Misses      26055    27459    +1404     
+ Partials     3368     3317      -51     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul changed the title feat: grc20 registry feat: add r/grc20reg + p/fqname Jul 5, 2024
Signed-off-by: moul <[email protected]>
@moul
Copy link
Member Author

moul commented Aug 29, 2024

Blocked by #2743

@moul moul mentioned this pull request Sep 17, 2024
7 tasks
thehowl added a commit that referenced this pull request Sep 18, 2024
Extracted from #2551 (also #2516).

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Morgan <[email protected]>
@moul moul changed the title feat: add r/grc20reg + p/fqname feat: add r/grc20reg Sep 21, 2024
@r3v4s
Copy link
Contributor

r3v4s commented Oct 27, 2024

First of all, I know that this pr is sill working in progress, but couldn't wait for charming of supporting multiple grc20 tokens by default in gno-eco system(in this case grc20reg) and did some test.

Currently, grc20reg takes object from other realm to register it, and it seems like affects stack-frame. (tested with _test.gno)

On the other hand, testing with txtar slightly returns different result, cannot modify external-realm or non-realm object.
Is this due to #2743 you mentioned blocked by ??

@moul
Copy link
Member Author

moul commented Oct 27, 2024

Yes, this grc20reg is no longer a work in progress, but it depends on the changes in the PR, specifically those in #2743.

For a preview of fully working examples, you can check my meta PR #2551, which includes some VM fixes, this completed realm, and other realms that use it, such as the atomicswap realm, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 🎯 Current Topics
Status: Triage
Development

Successfully merging this pull request may close these issues.

4 participants