Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/demo/atomicswap #2510

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open

Conversation

moul
Copy link
Member

@moul moul commented Jul 5, 2024

  • implement
  • unit test / txtar
  • question: ugnot or grc20 or both? Maybe it’s time to encourage using wugnot.
    -> both, with a callback mechanism.
  • question: p+r or just r?
    -> just r, and a single file. let's do it more!
  • make the API gnokey compatible + add Render.

Depends on #2529 (cherry-picked)
Depends on #2549 (cherry-picked)
Depends on #2551
Closes #2549

@moul moul self-assigned this Jul 5, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 5, 2024
Signed-off-by: moul <[email protected]>
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 5, 2024
Signed-off-by: moul <[email protected]>
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@moul
Copy link
Member Author

moul commented Jul 5, 2024

I think i'll try to be more grc20-centric for my demos. In involves writing some helpers to show how to actually come with gnot tokens, wrap then with wugnot. But also writing more and more grc20 examples: stupid ones, testing-purpose ones, etc.

@moul moul marked this pull request as ready for review July 6, 2024 20:26
@moul moul requested review from thehowl and a team as code owners July 6, 2024 20:26
@moul
Copy link
Member Author

moul commented Nov 16, 2024

Cherry-picked commits from #3135 to verify if atomicswap functions with the current VM. (See #2743 (comment)).

Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review November 18, 2024 09:10
@moul
Copy link
Member Author

moul commented Nov 18, 2024

#3135 to be merged before this one.

@gh-gno-bot
Copy link

gh-gno-bot commented Nov 28, 2024

Merge Requirements

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request
🟢 The pull request head branch must be up-to-date with its base

Details
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (moul:dev/moul/atomicswap) is up to date with base (master): behind by 0 / ahead by 87

Manual Checks

  • The pull request description provides enough details
Details
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 🙏🏻 To Delegate
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants