Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/demo/atomicswap #2510

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

Conversation

moul
Copy link
Member

@moul moul commented Jul 5, 2024

  • implement
  • unit test / txtar
  • question: ugnot or grc20 or both? Maybe it’s time to encourage using wugnot.
    -> both, with a callback mechanism.
  • question: p+r or just r?
    -> just r, and a single file. let's do it more!
  • make the API gnokey compatible + add Render.

Depends on #2529 (cherry-picked)
Depends on #2549 (cherry-picked)
Depends on #2551

@moul moul self-assigned this Jul 5, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 5, 2024
Signed-off-by: moul <[email protected]>
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 5, 2024
Signed-off-by: moul <[email protected]>
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.95%. Comparing base (0dc4b6d) to head (b05e615).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2510      +/-   ##
==========================================
- Coverage   54.96%   54.95%   -0.01%     
==========================================
  Files         595      595              
  Lines       79568    79568              
==========================================
- Hits        43731    43726       -5     
- Misses      32529    32533       +4     
- Partials     3308     3309       +1     
Flag Coverage Δ
contribs/gnodev 25.65% <ø> (-0.35%) ⬇️
contribs/gnofaucet 15.31% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 63.14% <ø> (ø)
gnovm 60.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member Author

moul commented Jul 5, 2024

I think i'll try to be more grc20-centric for my demos. In involves writing some helpers to show how to actually come with gnot tokens, wrap then with wugnot. But also writing more and more grc20 examples: stupid ones, testing-purpose ones, etc.

@moul moul marked this pull request as ready for review July 6, 2024 20:26
@moul moul requested review from thehowl and a team as code owners July 6, 2024 20:26
@moul moul added the don't merge Please don't merge this functionality temporarily label Jul 8, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 8, 2024
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review July 8, 2024 03:02
@moul moul requested review from zivkovicmilos and a team as code owners July 8, 2024 03:02
@moul moul changed the title feat: add r/demo/atomicswap + r/demo/tests/test20 feat: add r/demo/atomicswap Jul 8, 2024
@moul moul mentioned this pull request Jul 9, 2024
@moul moul marked this pull request as draft July 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 🙏🏻 To Delegate
Status: No status
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants