Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix output of urequire.PanicsWithMessage() #2506

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 4, 2024

Related to #2503

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from a team as code owners July 4, 2024 15:34
@linhpn99 linhpn99 requested review from jaekwon and zivkovicmilos and removed request for a team July 4, 2024 15:34
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 4, 2024
@linhpn99 linhpn99 changed the title Fix(examples): fix output of PanicsWithMessage fix(examples): fix output of PanicsWithMessage Jul 4, 2024
@linhpn99 linhpn99 changed the title fix(examples): fix output of PanicsWithMessage fix(examples): fix output of urequire.PanicsWithMessage() Jul 4, 2024
@leohhhn leohhhn requested a review from ajnavarro July 5, 2024 00:11
@leohhhn
Copy link
Contributor

leohhhn commented Jul 5, 2024

@ajnavarro can you take a look?

@zivkovicmilos zivkovicmilos merged commit 051bdc2 into gnolang:master Jul 5, 2024
9 checks passed
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Related to gnolang#2503

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants