chore(examples): Use uassert/urequire instead of testing in some demo packages #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhpn99
requested review from
mvertes and
ltzmaxwell
and removed request for
a team
moul
approved these changes
Jul 3, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
… packages (gnolang#2491) Related with gnolang#2481 This PR handles the following tasks: 1. Adds `NotEqual()` and `NotEmpty()` functions to the `p/demo/uassert` and `p/demo/ urequire` packages (including unit tests) 2. Uses `p/demo/uassert` and `p/demo/urequire` packages for writing unit tests for some demo packages at `examples/p/demo` 3. Todo : Do the same things with `examples/r/demo` (done) <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #2481
This PR handles the following tasks:
NotEqual()andNotEmpty()functions to thep/demo/uassertandp/demo/ urequirepackages (including unit tests)p/demo/uassertandp/demo/urequirepackages for writing unit tests for some demo packages atexamples/p/demoexamples/r/demo(done)Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description