-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p/uassert, p/diff): Support Diff in p/uassert
Package
#2490
Conversation
p/uassert
Packagep/uassert
Package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you for tackling this. Having a good diff algorithm in the general Gno toolset is very important, and your implementation of this one is nice and elegant. Excellent job!
In addition of my suggestions, I would also like to see the doc that this package deserves, for the exported types and functions. Thanks for your efforts.
Co-authored-by: Marc Vertes <[email protected]>
Co-authored-by: Marc Vertes <[email protected]>
Thanks you again for the review @mvertes! I think it has been improved thanks for you. I have applied most of the suggestions, but I've left one or two as they were due to issues related to Unicode processing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2490 +/- ##
=======================================
Coverage 55.01% 55.02%
=======================================
Files 595 595
Lines 79662 79662
=======================================
+ Hits 43830 43833 +3
+ Misses 32514 32513 -1
+ Partials 3318 3316 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implement the myers algorithm to show the difference between two strings. related with #2481
simple demo https://play.gno.land/p/Veoxvg1xwUb