Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p/uassert, p/diff): Support Diff in p/uassert Package #2490

Merged
merged 14 commits into from
Jul 23, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jul 3, 2024

Description

Implement the myers algorithm to show the difference between two strings. related with #2481

simple demo https://play.gno.land/p/Veoxvg1xwUb

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 3, 2024
@notJoon notJoon marked this pull request as ready for review July 3, 2024 08:14
@notJoon notJoon requested review from a team as code owners July 3, 2024 08:14
@notJoon notJoon requested review from deelawn and thehowl and removed request for a team July 3, 2024 08:14
@notJoon notJoon changed the title feat(p/uassert): Support Diff in p/uassert Package feat(p/uassert, p/diff): Support Diff in p/uassert Package Jul 5, 2024
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thank you for tackling this. Having a good diff algorithm in the general Gno toolset is very important, and your implementation of this one is nice and elegant. Excellent job!

In addition of my suggestions, I would also like to see the doc that this package deserves, for the exported types and functions. Thanks for your efforts.

examples/gno.land/p/demo/diff/diff.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/diff/diff.gno Show resolved Hide resolved
examples/gno.land/p/demo/diff/diff.gno Show resolved Hide resolved
examples/gno.land/p/demo/diff/diff.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/diff/diff.gno Outdated Show resolved Hide resolved
@notJoon
Copy link
Member Author

notJoon commented Jul 16, 2024

Thanks you again for the review @mvertes! I think it has been improved thanks for you. I have applied most of the suggestions, but I've left one or two as they were due to issues related to Unicode processing.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (fadf622) to head (71d1aff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2490   +/-   ##
=======================================
  Coverage   55.01%   55.02%           
=======================================
  Files         595      595           
  Lines       79662    79662           
=======================================
+ Hits        43830    43833    +3     
+ Misses      32514    32513    -1     
+ Partials     3318     3316    -2     
Flag Coverage Δ
gno.land 64.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deelawn deelawn merged commit 294ba90 into gnolang:master Jul 23, 2024
11 checks passed
@notJoon notJoon deleted the diff-in-assert branch July 23, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants