Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'gno mod tidy -v --recursive' flags #2485

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

moul
Copy link
Member

@moul moul commented Jul 3, 2024

cd examples; make tidy is now instant and verbose.

@moul moul self-assigned this Jul 3, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.70%. Comparing base (1c162de) to head (2f56693).

Files Patch % Lines
gnovm/cmd/gno/mod.go 60.52% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
- Coverage   54.70%   54.70%   -0.01%     
==========================================
  Files         590      590              
  Lines       79036    79068      +32     
==========================================
+ Hits        43236    43253      +17     
- Misses      32550    32561      +11     
- Partials     3250     3254       +4     
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.68% <ø> (ø)
gnovm 59.81% <60.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul marked this pull request as ready for review July 3, 2024 05:44
@moul moul requested review from thehowl and a team as code owners July 3, 2024 05:44
@moul moul requested review from jaekwon and removed request for a team July 3, 2024 05:44
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@moul moul merged commit 1169658 into gnolang:master Jul 6, 2024
89 checks passed
@moul moul deleted the dev/moul/tidy-rec branch July 6, 2024 14:24
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
`cd examples; make tidy` is now instant and verbose.

Signed-off-by: moul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants