-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnodev): add /reload and /reset endpoints #2448
Conversation
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
==========================================
- Coverage 54.70% 54.69% -0.02%
==========================================
Files 590 590
Lines 79036 79051 +15
==========================================
Hits 43236 43236
- Misses 32550 32565 +15
Partials 3250 3250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. I really like the idea of controlling Gnodev from the outside !
We can start with this simple API, but we may create a dedicated package for it if the API expands.
This exposes the
Reload
andReset
methods via http in gnodevIt allows to run UI E2E tests automatically without having to restart gnodev between each tests and thus makes usage in Cypress very easy
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description