Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnodev): add /reload and /reset endpoints #2448

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Jun 26, 2024

This exposes the Reload and Reset methods via http in gnodev
It allows to run UI E2E tests automatically without having to restart gnodev between each tests and thus makes usage in Cypress very easy

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.69%. Comparing base (1c162de) to head (aa1167b).

Files Patch % Lines
contribs/gnodev/cmd/gnodev/main.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
- Coverage   54.70%   54.69%   -0.02%     
==========================================
  Files         590      590              
  Lines       79036    79051      +15     
==========================================
  Hits        43236    43236              
- Misses      32550    32565      +15     
  Partials     3250     3250              
Flag Coverage Δ
contribs/gnodev 23.53% <0.00%> (-0.28%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. I really like the idea of controlling Gnodev from the outside !
We can start with this simple API, but we may create a dedicated package for it if the API expands.

@zivkovicmilos zivkovicmilos merged commit dea0df1 into gnolang:master Jul 6, 2024
75 of 77 checks passed
@n0izn0iz n0izn0iz deleted the gnodev-api-reset branch July 6, 2024 09:18
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants