Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): set otel service instance key id #2435

Merged

Conversation

mazzy89
Copy link
Contributor

@mazzy89 mazzy89 commented Jun 25, 2024

At the moment the OpenTelemetry ServiceInstanceKeyID is hardcoded. In the case of running multiple nodes (see the upcoming case of test4 multinode), we would want to distinguish the different instances. The ServiceInstanceKeyID is meant for that https://github.com/open-telemetry/opentelemetry-go/blob/5661ff0ded32cf1b83f1147dae96ca403c198504/semconv/v1.12.0/resource.go#L941

2024-06-25_13-48

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.68%. Comparing base (49fab4a) to head (dd21c44).

Files Patch % Lines
tm2/pkg/telemetry/metrics/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   54.67%   54.68%   +0.01%     
==========================================
  Files         583      583              
  Lines       78502    78503       +1     
==========================================
+ Hits        42923    42933      +10     
+ Misses      32371    32365       -6     
+ Partials     3208     3205       -3     
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.54% <ø> (ø)
tm2 54.38% <83.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mazzy89 mazzy89 changed the title feat: set otel service instance key id feat(telemetry): set otel service instance key id Jun 25, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 🙏

@zivkovicmilos zivkovicmilos merged commit 4f16ad3 into gnolang:master Jun 25, 2024
87 checks passed
@mazzy89 mazzy89 deleted the config-service-instance-key-id branch July 6, 2024 18:40
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants