Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: new txtar test for non-regression #2343

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

moul
Copy link
Member

@moul moul commented Jun 12, 2024

I don't think we need to merge this pull request, but I wanted to open it to check a few points:

  • We have three main folders containing txtar files. Is there a current contributing guideline explaining when to use one folder over another?
  • Is this test currently only testable using txtar, or is there a better approach?

@moul moul requested a review from gfanton as a code owner June 12, 2024 15:02
@moul moul self-assigned this Jun 12, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (3b42391) to head (88ebb51).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   54.71%   54.71%   -0.01%     
==========================================
  Files         590      590              
  Lines       79023    79023              
==========================================
- Hits        43238    43237       -1     
- Misses      32535    32536       +1     
  Partials     3250     3250              
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul changed the title dev/moul/new txtar New txtar test for non-regression Jun 12, 2024
@moul moul added the ❓ question Questions about Gno label Jun 12, 2024
@moul moul changed the title New txtar test for non-regression test: new txtar test for non-regression Jun 12, 2024
@deelawn
Copy link
Contributor

deelawn commented Jun 12, 2024

We have this issue as well to do part of this #2253

@thehowl
Copy link
Member

thehowl commented Jun 28, 2024

The way this can be done in filetests, is by adding the aaa packages in gnovm/tests/extern (which is a directory of imports, only available in filetests); and then doing the import in a filetest.

I think it makes sense to put it there, as it's testing GnoVM behaviour with imports, not gno.land behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related ❓ question Questions about Gno
Projects
Status: No status
Status: 📥 Inbox
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants