Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add two new upgrade examples + refactor existing ones #2334

Merged
merged 31 commits into from
Jul 24, 2024

Conversation

moul
Copy link
Member

@moul moul commented Jun 12, 2024

Depends on #2342

cc @jeronimoalbi

@moul moul requested review from a team as code owners June 12, 2024 07:07
@moul moul removed the request for review from a team June 12, 2024 07:07
@moul moul self-assigned this Jun 12, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 12, 2024
@moul moul mentioned this pull request Jun 12, 2024
@moul moul mentioned this pull request Jun 12, 2024
Signed-off-by: moul <[email protected]>
@moul moul changed the title chore: add two new upgrade examples chore: add two new upgrade examples + refactor existing ones Jun 12, 2024
@jeronimoalbi
Copy link
Member

I really like the approach taken in upgrade_e and upgrade_f, they are elegant and idiomatic 👍

I'm wondering if it makes sense to eventually have another upgrade example case, where the "home" realm is actually versioned using v1, v2, and so on in the realm path for major versions, where the inner interface implementations from upgrade_e are considered minor versions. If this makes sense, it would allow "home" to eventually be bumped up to a new major version when any public realm functions or the interface changes.

@moul
Copy link
Member Author

moul commented Jun 19, 2024

I'm wondering if it makes sense to eventually have another upgrade example case, where the "home" realm is actually versioned using v1, v2, and so on in the realm path for major versions, where the inner interface implementations from upgrade_e are considered minor versions. If this makes sense, it would allow "home" to eventually be bumped up to a new major version when any public realm functions or the interface changes.

To be tried!

moul added a commit that referenced this pull request Jul 6, 2024
This package demonstrates a new access control pattern relying on
package paths.

It considers that the #1107 feature is already implemented to rely on
the built-in security.

You can see an ongoing usage in #2334.

---------

Signed-off-by: moul <[email protected]>
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
This package demonstrates a new access control pattern relying on
package paths.

It considers that the gnolang#1107 feature is already implemented to rely on
the built-in security.

You can see an ongoing usage in gnolang#2334.

---------

Signed-off-by: moul <[email protected]>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (b1c1c96) to head (85556b9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   55.01%   55.00%   -0.01%     
==========================================
  Files         595      595              
  Lines       79765    79792      +27     
==========================================
+ Hits        43880    43890      +10     
- Misses      32567    32584      +17     
  Partials     3318     3318              
Flag Coverage Δ
gno.land 64.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 8865638 into gnolang:master Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants