-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnokey): update gnokey verify and tests #2333
base: master
Are you sure you want to change the base?
feat(gnokey): update gnokey verify and tests #2333
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2333 +/- ##
==========================================
+ Coverage 60.44% 60.99% +0.55%
==========================================
Files 563 564 +1
Lines 75159 76006 +847
==========================================
+ Hits 45427 46358 +931
+ Misses 26343 26217 -126
- Partials 3389 3431 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @thinhnx-var thanks for this - can you please check why the CI is failing and fix it? |
@leohhhn yeah sure. Maybe CI failed because CI-Lint. I gonna fix it up. |
@leohhhn |
Hey! I will take a look. Please stop clicking "merge master". This is annoying and spammy, and will not get your PR reviewed faster. You should only merge in master if there are conflicts to be resolved. |
Removed the "review team" label because this is already reviewed by leohhhn. |
Co-authored-by: Jeff Thompson <[email protected]>
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the descriptionLink to this issue: #2311
This PR changes the
Verify()
to read thesigned doc
, verify the exactly original message hash that was signed.It also adds
chainid
,account-number
,account-sequence
config flag to thegnokey verify
command.The
sign
function now expose thehex-format of signature
to the IO in oder to feed theverify
as an argument. I think we need better way for user to verify their signed document, which currently need thishex-format
(#2272)What do you think about this change?