feat: improve p/ownable API #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <[email protected]>
github-actions
bot
added
the
🧾 package/realm
This was referenced Jun 11, 2024
Signed-off-by: moul <[email protected]>
|
@linhpn99, I've left several comments. Your implementation is not yet ready. You'll need to update your pull request based on these new additions. |
Signed-off-by: moul <[email protected]>
leohhhn
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
This was on my mind for some time now - thanks for adding this.
I think we should also add event support for TransferOwnership & DropOwnership while we're at it.
This could be simply one event, OwnershipTransfer, which would show the new owner, and in case of DropOwnership, would emit an empty address for the new owner.
Signed-off-by: moul <[email protected]>
|
Added std.Emit. But I don't know how to test them from unit tests. |
leohhhn
reviewed
Jun 12, 2024
leohhhn
reviewed
Jun 12, 2024
thehowl
approved these changes
Jun 13, 2024
zivkovicmilos
added a commit
that referenced
this pull request
Jul 8, 2024
This PR introduces the `r/gnoland/monit` realm, which can be used by an external tool to verify if everything is working well, including: - gnokey compatibility (and all the tx/amino/etc) - networking (rpc) - realm state persistency (counter should be higher than the previous value) In addition to being a good target for an external monitoring agent, the realm displays (`Render`) some information, including whether the agent appears to be missing. - [x] improve ownable (depends on #2330) - [x] p/demo/watchdog - [x] r/gnoland/monit - [ ] ~update contribs/autocounterd~ -> let's @gnolang/devops tackle this in another PR. -> #1443 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
This PR introduces the `r/gnoland/monit` realm, which can be used by an external tool to verify if everything is working well, including: - gnokey compatibility (and all the tx/amino/etc) - networking (rpc) - realm state persistency (counter should be higher than the previous value) In addition to being a good target for an external monitoring agent, the realm displays (`Render`) some information, including whether the agent appears to be missing. - [x] improve ownable (depends on gnolang#2330) - [x] p/demo/watchdog - [x] r/gnoland/monit - [ ] ~update contribs/autocounterd~ -> let's @gnolang/devops tackle this in another PR. -> gnolang#1443 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Miloš Živković <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the
p/ownableAPI based on my needs encountered recently.std.TestSetRealm(cc @thehowl)Part of #2150