-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnoweb): update "airgapped" commands in realm help page #2244
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
==========================================
- Coverage 54.60% 49.95% -4.66%
==========================================
Files 579 578 -1
Lines 77896 77794 -102
==========================================
- Hits 42539 38861 -3678
- Misses 32185 35809 +3624
+ Partials 3172 3124 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you add a In addition, this will allow me to reuse the |
Btw, I think that #1976 removes the possibility to sign the same tx twice, with two different accounts from CLI. |
@moul done; some fine tuning to get there as not all commands in gnokey were actually using |
yes, I have some doubts about what the PR did as well. I've asked milos to clarify, but we may end up changing some behaviour again. |
This matches
gnokey sign
's behaviour to the updated version from #1976. I've manually tested this on a local node, and it works.