Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test gno.land when changing gnovm and tm2 #2215

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 27, 2024

I'd like if we had good tests and decoupled components that could make this unnecessary. However I believe it's still the case that modifying something in tm2 and gnovm can create issues on gno.land without showing up on the CI, seeing as it is the component that strictly depends on both tm2 and gnovm.

@thehowl thehowl requested a review from ajnavarro May 27, 2024 13:35
@thehowl thehowl self-assigned this May 27, 2024
@thehowl thehowl requested review from moul and a team as code owners May 27, 2024 13:35
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (aa9c64a) to head (e2a99fa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
- Coverage   54.63%   54.63%   -0.01%     
==========================================
  Files         581      581              
  Lines       77967    78077     +110     
==========================================
+ Hits        42601    42661      +60     
- Misses      32186    32235      +49     
- Partials     3180     3181       +1     
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 61.86% <ø> (ø)
gnovm 60.06% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.47% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to mess up code coverage...

If we need some kind of integration tests, we should add them inside gno.land folder.

@thehowl
Copy link
Member Author

thehowl commented Jun 6, 2024

I think this is going to mess up code coverage...

Wdym? How could this mess up the coverage?

Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I thought that codecov will be confused if we added the same coverage for several tags, but it might not be the case.

@ajnavarro ajnavarro merged commit 6284669 into master Jun 18, 2024
80 checks passed
@ajnavarro ajnavarro deleted the dev/morgan/gnoland-test-always branch June 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants