-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactoring build of docker images #2199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2199 +/- ##
==========================================
- Coverage 49.09% 49.08% -0.01%
==========================================
Files 576 576
Lines 77821 77821
==========================================
- Hits 38204 38200 -4
- Misses 36523 36528 +5
+ Partials 3094 3093 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
i need to test the images, it should works, not 100% sure |
All good for review :) @gfanton @ajnavarro |
agreed w/ albert to close |
This is a following of :
I am a big fan of goreleaser, but it seems that building docker images with it isn't a really good idea at the moment...
Currently, it seems to not have a latest build, only a nighly, which break portal-loop / staging ...
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description