Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring build of docker images #2199

Closed
wants to merge 15 commits into from
Closed

feat: refactoring build of docker images #2199

wants to merge 15 commits into from

Conversation

albttx
Copy link
Member

@albttx albttx commented May 26, 2024

This is a following of :

I am a big fan of goreleaser, but it seems that building docker images with it isn't a really good idea at the moment...

Currently, it seems to not have a latest build, only a nighly, which break portal-loop / staging ...

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@albttx albttx requested review from moul and a team as code owners May 26, 2024 09:19
@albttx albttx requested review from piux2 and removed request for a team May 26, 2024 09:19
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.08%. Comparing base (1a53255) to head (b7df978).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   49.09%   49.08%   -0.01%     
==========================================
  Files         576      576              
  Lines       77821    77821              
==========================================
- Hits        38204    38200       -4     
- Misses      36523    36528       +5     
+ Partials     3094     3093       -1     
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 61.62% <ø> (ø)
gnovm 42.20% <ø> (-0.02%) ⬇️
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (ø)
misc/loop 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx
Copy link
Member Author

albttx commented May 26, 2024

Cached is working, build time highly reduced

image

@albttx
Copy link
Member Author

albttx commented May 26, 2024

i need to test the images, it should works, not 100% sure

@zivkovicmilos zivkovicmilos changed the title Refactoring: Build of docker images feat: refactoring build of docker images May 26, 2024
@albttx albttx mentioned this pull request May 27, 2024
7 tasks
@albttx
Copy link
Member Author

albttx commented May 27, 2024

All good for review :) @gfanton @ajnavarro

@thehowl
Copy link
Member

thehowl commented May 30, 2024

agreed w/ albert to close

@thehowl thehowl closed this May 30, 2024
@thehowl thehowl deleted the ci/docker branch May 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants