Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tm2/crypto): do not use build tags to mock ledger #2173

Merged
merged 3 commits into from
May 23, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 23, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this May 23, 2024
@thehowl thehowl requested review from jaekwon, a team and moul as code owners May 23, 2024 11:50
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 49.07%. Comparing base (e1586a5) to head (d17a478).
Report is 4 commits behind head on master.

Files Patch % Lines
tm2/pkg/crypto/internal/ledger/discover.go 50.00% 11 Missing ⚠️
tm2/pkg/crypto/ledger/ledger_secp256k1.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
+ Coverage   49.01%   49.07%   +0.06%     
==========================================
  Files         576      576              
  Lines       77604    77621      +17     
==========================================
+ Hits        38035    38090      +55     
+ Misses      36486    36439      -47     
- Partials     3083     3092       +9     
Flag Coverage Δ
tm2 54.72% <50.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 🙏

tm2/pkg/crypto/keys/client/add_ledger_test.go Show resolved Hide resolved
blame the linter

This reverts commit db5fc7d.
@thehowl thehowl merged commit 11e13f8 into master May 23, 2024
39 checks passed
@thehowl thehowl deleted the dev/morgan/remove-ledger-suite-tag branch May 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants