Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): remove sort from gonative packages #2168

Merged
merged 1 commit into from
May 23, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 22, 2024

Fixes #2139.

Removing sort from the list of native packages allows tests to use the full-Gno sort implementation, which has support for sort.Sort and will not cause the panic mentioned by @leohhhn.

@thehowl thehowl self-assigned this May 22, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (307b3d9) to head (472fd2f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   49.00%   48.99%   -0.02%     
==========================================
  Files         576      576              
  Lines       77604    77599       -5     
==========================================
- Hits        38033    38021      -12     
- Misses      36486    36492       +6     
- Partials     3085     3086       +1     
Flag Coverage Δ
gnovm 41.92% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 16ed32f into master May 23, 2024
47 checks passed
@thehowl thehowl deleted the dev/morgan/remove-sort-native branch May 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[GnoVM] Regexp breaking when used in stdlibs
2 participants