Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): remove function #2154

Merged
merged 2 commits into from
May 20, 2024
Merged

fix(blog): remove function #2154

merged 2 commits into from
May 20, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented May 20, 2024

Description

This PR adds better removing to the blog Remove function.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label May 20, 2024
@leohhhn leohhhn marked this pull request as ready for review May 20, 2024 19:24
@leohhhn leohhhn requested review from moul and a team as code owners May 20, 2024 19:24
@leohhhn leohhhn merged commit a7ec2ab into gnolang:master May 20, 2024
11 checks passed
@leohhhn leohhhn deleted the fix/blog-remove branch May 20, 2024 19:29
leohhhn added a commit to leohhhn/gno that referenced this pull request May 21, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

This PR adds better removing to the blog `Remove` function.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants