-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gno): use verbose
flag to print emitted events
#2071
Closed
r3v4s
wants to merge
7
commits into
gnolang:master
from
gnoswap-labs:feat/print-emit-during-gno-test
Closed
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
921299a
feat: add `-print-events` flag to `gno test` to print emitted events
r3v4s 2cf4dec
feat: divide and print events for every test functions
r3v4s 446eee7
refactor: use `verbose` flag to print event or not
r3v4s 68d336c
test
r3v4s 4f46c48
chore: fmt
r3v4s 8fa74d2
Merge branch 'master' into feat/print-emit-during-gno-test
r3v4s 984093b
fix: use test context
r3v4s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Test-print-events flag | ||
|
||
gno test -print-events=true . | ||
|
||
! stdout .+ | ||
stderr '--- event: +' | ||
|
||
-- valid.gno -- | ||
package valid | ||
|
||
import "std" | ||
|
||
func Hello() { | ||
std.Emit("emit_in_pkg", "k1", "v1") | ||
} | ||
|
||
-- valid_test.gno -- | ||
package valid | ||
|
||
import "testing" | ||
|
||
func TestHello(t *testing.T) { | ||
Hello() | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @moul, I think we should print these events if the
verbose
flag is enabled, and not hide this functionality behind an additional flag we need to now maintainThe reasoning is that events are now an integral part of the Gno development lifecycle, and not a "feature" we can disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally understand, however for easier(or at least more readable) debugging flags needs to be separated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
446eee7