-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): emit/event docs #2047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it strange that you didn't mention the required PR on the docs repo anywhere:
gnolang/docs.gno.land#29
Please fix the failing PR on that repo, it can't even build because of invalid IDs.
We can see what to do about this one after that
Also, please add adequate labels to this PR 🙏
Hey @zivkovicmilos,
I've linked this PR in the docs.gno.land repo PR, so the connection should be visible (right above your comment).
Due to the setup that we currently have with the documentation infra, it is currently not possible to build or preview the documentation on the docs.gno.land repo - which is why the CI is red on the mentioned PR. Specifically, this is because the CI on the other repo fetches the monorepo Currently, the only way to get the CI fixed on the other repo is to merge content here first. This PR is ready for review - please convert it back to the correct status 🙏
Added the docs label - I was under the impression that we have a bot doing that for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor things, but overall it's well written. 👍
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR adds docs for emit/event. It adds reference docs, and a section in effective Gno. More practical examples will be added to Gno By Example. Closes: gnolang#2003 <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Lee ByeongJun <[email protected]>
Description
This PR adds docs for emit/event. It adds reference docs, and a section in effective Gno. More practical examples will be added to Gno By Example.
Closes: #2003
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description