-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2035): Prevent infinite loops caused by cyclic references on typedValue #2036
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
- Coverage 46.74% 46.74% -0.01%
==========================================
Files 492 492
Lines 69616 69614 -2
==========================================
- Hits 32542 32539 -3
- Misses 34363 34364 +1
Partials 2711 2711 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying and solving this bug. Could make the same change for the map key as well and add a file test to demonstrate the issue is fixed?
Thank you for your review. ^^ |
I guess what @deelawn suggests is that you can have another test file show case using a struct as key of a map to prove you modification thoroughly. But actually I found another bug from this direction, see #2041. cc @deelawn . |
Closes #2035.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description