Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tm2): add prometheus exporter #2032

Closed
wants to merge 3 commits into from
Closed

chore(tm2): add prometheus exporter #2032

wants to merge 3 commits into from

Conversation

albttx
Copy link
Member

@albttx albttx commented May 3, 2024

This PR add a prometheus exporter, and keep the current opentelemetry exporter.

Both can live side by side.

I understand opentelemetry, but it's really more convinient to have a prometheus exporter which is a "default" you find everywhere.

This PR also add a new metrics for Block Interval

This is a first draft, let's discuss about it

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 3, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.38%. Comparing base (6482c18) to head (d8436a2).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
+ Coverage   47.29%   48.38%   +1.08%     
==========================================
  Files         362      409      +47     
  Lines       58590    62036    +3446     
==========================================
+ Hits        27713    30019    +2306     
- Misses      28594    29517     +923     
- Partials     2283     2500     +217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx albttx mentioned this pull request May 9, 2024
23 tasks
@albttx
Copy link
Member Author

albttx commented May 9, 2024

following internal discussion with @zivkovicmilos and @ajnavarro decision taken is to continue with OTEL, closing this

@albttx albttx closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant