-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify staging #2018
chore: simplify staging #2018
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
- Coverage 60.23% 60.23% -0.01%
==========================================
Files 562 562
Lines 75026 75026
==========================================
- Hits 45192 45189 -3
- Misses 26462 26466 +4
+ Partials 3372 3371 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks better. However, staging should not just update with new commits but also restart regularly, like every hour. Please, maintain this periodic schedule as well. |
Sure, what do you prefer?
I can add something like: restarter:
image: docker:cli
volumes: ["/var/run/docker.sock:/var/run/docker.sock"]
command: ["/bin/sh", "-c", "while true; do sleep 86400; docker restart ${CONTAINER_NAME}; done"] or restarter:
image: docker:cli
restart: unless-stopped
volumes: ["/var/run/docker.sock:/var/run/docker.sock"]
entrypoint: ["/bin/sh","-c"]
command:
- |
while true; do
if [ "$$(date +'%H:%M')" = '20:00' ]; then
docker restart myservice
fi
sleep 60
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix 🙏
I've left a few comments
Please update the appropriate docs as well, in |
All good ! :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good on the docs side - thanks @albttx!
This simplify the staging servers system.
It's using the docker image: watchtower to automatically pull-update new gno versions.
It's currently deployed on the server: we now have
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description