-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#1966): go2Gno loses type info #2016
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
- Coverage 49.04% 48.85% -0.20%
==========================================
Files 576 579 +3
Lines 77556 78038 +482
==========================================
+ Hits 38035 38122 +87
- Misses 36439 36830 +391
- Partials 3082 3086 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @ltzmaxwell |
thank you for your work, start looking. |
cc @deelawn for a second look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix up the unit tests; after that we're good to go.
fixes #1966
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description