Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoland): pass genesis file as a flag #1972

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Apr 23, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Apr 23, 2024
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 46.26%. Comparing base (06e8783) to head (e1a5d32).
Report is 1 commits behind head on master.

Files Patch % Lines
gno.land/cmd/gnoland/start.go 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1972   +/-   ##
=======================================
  Coverage   46.26%   46.26%           
=======================================
  Files         482      483    +1     
  Lines       68817    68841   +24     
=======================================
+ Hits        31838    31851   +13     
- Misses      34350    34359    +9     
- Partials     2629     2631    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member Author

thehowl commented Apr 24, 2024

@zivkovicmilos This PR is good to go, here is the diff.

I'll keep it in draft for now, fix it up after your PR is merged and then mark it as ready for review

I suggest you to start pushing directly to gnolang/gno rather than your fork so these "stacks" become easier 🙏

zivkovicmilos added a commit to zivkovicmilos/gno that referenced this pull request Apr 24, 2024
@zivkovicmilos zivkovicmilos marked this pull request as ready for review April 25, 2024 13:09
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@thehowl thehowl merged commit ee9e2e2 into master Apr 25, 2024
189 checks passed
@thehowl thehowl deleted the dev/morgan/genesis-json-flag branch April 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[chain] Add a genesis.json path flag to gnoland start
4 participants