Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: portal loop small fixes #1959

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Conversation

moul
Copy link
Member

@moul moul commented Apr 19, 2024

-> #2496

@moul moul self-assigned this Apr 19, 2024
@moul moul changed the title dev/moul/fix portal loop chore: portal loop small fixes Apr 19, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (c628334) to head (066a4b2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1959   +/-   ##
=======================================
  Coverage   48.25%   48.25%           
=======================================
  Files         408      408           
  Lines       62338    62338           
=======================================
  Hits        30081    30081           
  Misses      29749    29749           
  Partials     2508     2508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member Author

moul commented Jul 4, 2024

It's an old PR. I'll merge without review. I'll open a "good first issue" to fix the links on the portal loop.

@moul moul marked this pull request as ready for review July 4, 2024 01:20
@moul moul mentioned this pull request Jul 4, 2024
@moul moul merged commit 88a417b into gnolang:master Jul 4, 2024
8 of 9 checks passed
@moul moul deleted the dev/moul/fix-portal-loop branch July 4, 2024 01:22
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant