Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: move genesis to gnoland genesis #1954

Merged
merged 5 commits into from
Apr 19, 2024
Merged

refactor!: move genesis to gnoland genesis #1954

merged 5 commits into from
Apr 19, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

Closes #1953

This PR moves the genesis command suite to be a subcommand of gnoland, making it callable with gnoland genesis.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Apr 18, 2024
@zivkovicmilos zivkovicmilos self-assigned this Apr 18, 2024
@zivkovicmilos zivkovicmilos requested review from thehowl and a team April 18, 2024 16:20
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (7ecc692) to head (190d51a).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   45.17%   48.25%   +3.08%     
==========================================
  Files         465      408      -57     
  Lines       68081    62338    -5743     
==========================================
- Hits        30753    30081     -672     
+ Misses      34747    29749    -4998     
+ Partials     2581     2508      -73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harry-hov harry-hov changed the title feat: move genesis to gnoland genesis refactor!: move genesis to gnoland genesis Apr 19, 2024
thehowl
thehowl reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move all the files for the genesis commands to have the prefix genesis_? (so genesis_balances.go, etc.)

I would also personally prefer if we didn't have as many files in the directory; ie. group genesis_balances subcommands and genesis_txs subcommands together; this can be tackled in another PR, though.

@zivkovicmilos
Copy link
Member Author

Can we move all the files for the genesis commands to have the prefix genesis_? (so genesis_balances.go, etc.)

I would also personally prefer if we didn't have as many files in the directory; ie. group genesis_balances subcommands and genesis_txs subcommands together; this can be tackled in another PR, though.

🤦‍♂️

I completely forgot to do this as a final step 🙃

Fixed:
190d51a

@thehowl thehowl merged commit c628334 into gnolang:master Apr 19, 2024
186 of 189 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/move-genesis branch April 20, 2024 10:23
omarsy pushed a commit to TERITORI/gno that referenced this pull request Apr 21, 2024
@zivkovicmilos @omarsy
refactor!: move genesis to gnoland genesis (gnolang#1954)
3857344 
## Description

Closes gnolang#1953 

This PR moves the `genesis` command suite to be a subcommand of
`gnoland`, making it callable with `gnoland genesis`.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@Kouteki Kouteki mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl left review comments

@harry-hov harry-hov harry-hov approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@moul moul Awaiting requested review from moul

Assignees

@zivkovicmilos zivkovicmilos

Labels
breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
💪 Bounties & Worx
Status: Done
🧐 Review Meeting
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
🏗4️⃣ test4.gno.land
Development

Successfully merging this pull request may close these issues.

[chain] Move the genesis command suite to gnoland genesis
4 participants
@zivkovicmilos @ajnavarro @thehowl @harry-hov