chore: rename r/system -> r/sys #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
- Coverage 47.78% 45.17% -2.61%
==========================================
Files 393 465 +72
Lines 61608 68087 +6479
==========================================
+ Hits 29437 30758 +1321
- Misses 29701 34751 +5050
- Partials 2470 2578 +108 ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <[email protected]>
moul-bot
force-pushed
the
dev/moul/system-sys
branch
from
9da58a0 to
4395fc8
Compare
4 tasks
zivkovicmilos
approved these changes
Apr 18, 2024
|
The |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
thehowl
approved these changes
Apr 18, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
- Renamed `r/system/*` to `r/sys`. - Updated configuration files. - Added comments, documentation, and notes. --------- Signed-off-by: moul <[email protected]>
zivkovicmilos
added a commit
that referenced
this pull request
Jun 12, 2024
This PR showcases a model that combines multiple contracts with defined
goals and constraints. The aim is to make everything in `sys/*` usable
by the chain (tm2 powered) efficiently, with minimal need for updates
while maintaining flexibility in usage.
The `sys/` contracts focus on defining data types and helpers to ensure
that received callbacks meet minimal constraints, like GovDAO approval.
They do not handle DAO logic or state due to complexity and
upgradability requirements for DAOs.
I won't include complete DAO examples in this PR. Imagine having these
sections once everything is done:
- `{p,r}/sys: minimal interface with the chain`
- `{p,r}/gov: simple DAO frameworks`
- `{p,r}/*`: where users will develop permissionless logic and propose
it to `gov` for approval using `sys` to trigger the chain.
Personal note -> try to introduce and document the notion of "pausable
threads". Related with #1974.
---
TODO:
- [x] pseudo-code for proof of conribution's valset management.
- [x] proposal example.
- [ ] pseudo-code for gnosdk v0 to catch the event and apply the change
from tm2. cc @gfanton
- [ ] add unit-tests, to illustrate the expected usage.
depends on std.Emit (#575).
depends on #1948 (need rebase).
---------
Signed-off-by: moul <[email protected]>
Signed-off-by: gfanton <[email protected]>
Co-authored-by: Milos Zivkovic <[email protected]>
Co-authored-by: gfanton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r/system/*tor/sys.