refactor: addr_set.gno modification proposal #1947
Draft
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leohhhn @zivkovicmilos @jaekwon I was looking on std package by curiosity and saw some TODOs on the add_set.gno file, so I made this PR. Is my commit OK/good? |
MalekLahbib
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
- Coverage 48.25% 47.20% -1.06%
==========================================
Files 408 362 -46
Lines 62338 59027 -3311
==========================================
- Hits 30081 27861 -2220
+ Misses 29749 28862 -887
+ Partials 2508 2304 -204 ☔ View full report in Codecov by Sentry. |
…ons to the struct
|
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As I was diving into the std package, I saw some TODOs on addr_set.gno, where @jaekwon proposes to use avl tree (binary tree) to optimize the code.
So as a contribution, I modified the file so that the structure and all the functions use avl package. (Many thanks to @moul for trusting us and giving the inspiration/confidence, and @leohhhn and others from the team for helping us each time we need it)
I don't know if the way I modified the file corresponds to @jaekwon idea/vision of the thing.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description