Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoclient): support fetching blocks, block results, latest block number #1910

Merged
merged 15 commits into from
Apr 29, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Apr 10, 2024

Description

This PR adds gnoclient support for fetching blocks, block results, and the latest block number.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 46.41%. Comparing base (fdde3d0) to head (eee2e87).

Files Patch % Lines
gno.land/pkg/gnoclient/client_queries.go 76.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1910   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files         487      487           
  Lines       68973    68998   +25     
=======================================
+ Hits        32011    32026   +15     
- Misses      34313    34318    +5     
- Partials     2649     2654    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn requested a review from gfanton April 10, 2024 10:45
@leohhhn leohhhn marked this pull request as ready for review April 10, 2024 10:45
@leohhhn leohhhn requested a review from moul as a code owner April 10, 2024 10:45
@harry-hov
Copy link
Contributor

please run make fmt!

@harry-hov harry-hov self-requested a review April 11, 2024 13:20
@leohhhn leohhhn changed the title feat(gnoclient): support fetching blocks & transactions feat(gnoclient): support fetching blocks, block results, latest block number Apr 13, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just left a few comments 🙏

gno.land/pkg/gnoclient/client_queries.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_queries.go Show resolved Hide resolved
gno.land/pkg/gnoclient/client_test.go Show resolved Hide resolved
@leohhhn
Copy link
Contributor Author

leohhhn commented Apr 26, 2024

Please do not merge - need to finish up the docs for this.

@leohhhn leohhhn requested a review from a team as a code owner April 29, 2024 13:25
@leohhhn leohhhn merged commit cb90aaa into gnolang:master Apr 29, 2024
75 of 78 checks passed
@leohhhn leohhhn deleted the gnoclient/block-and-tx branch April 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: No status
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[gnoclient] Add support for fetching blocks & transaction data
3 participants