-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnoclient): add support for MsgAddPackage
#1892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
+ Coverage 47.74% 47.76% +0.02%
==========================================
Files 393 393
Lines 61629 61664 +35
==========================================
+ Hits 29424 29456 +32
+ Misses 29734 29731 -3
- Partials 2471 2477 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
Pinging @gfanton to sign off and we can merge 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I would add a usage example on how you can read and add a std.MemPackage
. It can be tricky for a new user to figure out how to do that.
Description
This PR adds gnoclient support for
MsgAddPackage
, and updates the docs to match the functionality. Docs preview: https://www.loom.com/share/0dfa38e6e95e4e1195d686c8cbffa453?sid=4af29ee0-d065-442c-977e-ce9577796688Closes #1840
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description