Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update creating-grc20.md #1771

Merged
merged 2 commits into from
Mar 14, 2024
Merged

docs: Update creating-grc20.md #1771

merged 2 commits into from
Mar 14, 2024

Conversation

kazai777
Copy link
Contributor

add missing imports and modified the call to AddressOrName() by adding an alias pusers to access the users package functions. And modified calls to Resolve() by adding the prefix users.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

add missing imports and modified the call to `AddressOrName()` by adding an alias `pusers` to access the `users` package functions. And modified calls to `Resolve()` by adding the prefix `users`.
@kazai777 kazai777 requested a review from a team as a code owner March 13, 2024 21:47
@thehowl thehowl requested a review from leohhhn March 14, 2024 14:34
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PR fixing all of these things, and more: #1766 - but it is currently waiting on a small feature request in the Playground (https://github.com/gnostudio/studio/issues/575).
I will merge this for now.

@leohhhn leohhhn merged commit c20d4ec into gnolang:master Mar 14, 2024
6 checks passed
@leohhhn leohhhn mentioned this pull request Mar 14, 2024
7 tasks
albttx pushed a commit to albttx/gno that referenced this pull request Mar 15, 2024
add missing imports and modified the call to `AddressOrName()` by adding
an alias `pusers` to access the `users` package functions. And modified
calls to `Resolve()` by adding the prefix `users`.

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

Co-authored-by: Leon Hudak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants