Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(txtar): handle quote for gnokey #1745

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Mar 7, 2024

Following #1736

This PR updates the gnokey command to better handle quotes within txtar. This is useful for commands like query:

gnokey query vm/qrender --data "gno.land/r/append\n"

The update means gnokey can now handle:
• Arguments in quotes that contain spaces or special characters.
• Escape sequences inside quotes.

See tests for more concrete examples.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 7, 2024
@gfanton gfanton requested a review from deelawn March 7, 2024 10:16
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.72%. Comparing base (45c8f90) to head (7eb86e7).

Files Patch % Lines
gno.land/pkg/integration/testing_integration.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
- Coverage   47.41%   44.72%   -2.70%     
==========================================
  Files         384      456      +72     
  Lines       61187    67543    +6356     
==========================================
+ Hits        29014    30209    +1195     
- Misses      29744    34806    +5062     
- Partials     2429     2528      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gfanton <[email protected]>
Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea for a PR. Looks good to me 👍

gno.land/pkg/integration/integration_test.go Show resolved Hide resolved
gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding good coverage 🙏

Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfanton gfanton merged commit 1a19359 into gnolang:master Mar 11, 2024
183 checks passed
@gfanton gfanton deleted the feat/txtar-unescape branch March 11, 2024 08:47
albttx pushed a commit to albttx/gno that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants