-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txtar): handle quote for gnokey #1745
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 47.41% 44.72% -2.70%
==========================================
Files 384 456 +72
Lines 61187 67543 +6356
==========================================
+ Hits 29014 30209 +1195
- Misses 29744 34806 +5062
- Partials 2429 2528 +99 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea for a PR. Looks good to me 👍
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding good coverage 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following #1736
This PR updates the
gnokey
command to better handle quotes withintxtar
. This is useful for commands likequery
:gnokey query vm/qrender --data "gno.land/r/append\n"
The update means
gnokey
can now handle:• Arguments in quotes that contain spaces or special characters.
• Escape sequences inside quotes.
See tests for more concrete examples.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description