Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(r/demo/tests): add filetest for PrevRealm #1705

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

grepsuzette
Copy link
Contributor

@grepsuzette grepsuzette commented Feb 29, 2024

PrevRealm was tested from gno/examples/gno.land/r/demo/tests/tests_test.gnotest.
As far as I can see in r/demo/tests however, it was not tested for filetests.

Although gno test . passes, depending on whether #1704 is confirmed, there may be more filetests to add in this folder (in a different PR I guess).

@grepsuzette grepsuzette requested review from a team as code owners February 29, 2024 03:33
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.90%. Comparing base (11a5027) to head (263a62f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   60.92%   60.90%   -0.02%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45857    45842      -15     
- Misses      26048    26058      +10     
- Partials     3368     3373       +5     
Flag Coverage Δ
contribs/gnodev 60.65% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.17% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 61.99% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/gno.land/r/demo/tests/z2_filetest.gno Outdated Show resolved Hide resolved
@thehowl thehowl changed the title add filetest for PrevRealm in demo/tests test(r/demo/tests): add filetest for PrevRealm Mar 6, 2024
@grepsuzette
Copy link
Contributor Author

I don't understand why the test fails with

PASS
coverage: 33.3% of statements
ok  	github.com/gnolang/gno/tm2/pkg/bft/rpc/lib/types	0.005s	coverage: 33.3% of statements
	github.com/gnolang/gno/tm2/pkg/bft/rpc/test		coverage: 0.0% of statements
# github.com/jmhodges/levigo
Error: ../../../../go/pkg/mod/github.com/jmhodges/[email protected]/batch.go:4:11: fatal error: leveldb/c.h: No such file or directory
    4 | // #include "leveldb/c.h"
      |           ^~~~~~~~~~~~~
compilation terminated.
Error: The operation was canceled.

grepsuzette added a commit to grepsuzette/gno that referenced this pull request Mar 18, 2024
seems PrevRealm was tested from test but not from filetest

This is based on gno/examples/gno.land/r/demo/tests/tests_test.gno
@grepsuzette
Copy link
Contributor Author

Did rebase and checks now pass.
This PR should be good to go.

@thehowl thehowl merged commit bdd91ce into gnolang:master Oct 2, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants