Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add code facilitators ci #1660

Closed

Conversation

0xtekgrinder
Copy link

@0xtekgrinder 0xtekgrinder commented Feb 15, 2024

Add a system based on #1466 issue that add a CODEFACILITATORS file and a script to assign PRs similar to how code owners works and add a message to the PR explaining their roles.

It uses a github action created for this specific purpose in https://github.com/0xtekgrinder/codefacilitators

The logic of the action is located in https://github.com/0xtekgrinder/codefacilitators/blob/main/src/main.ts

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.11%. Comparing base (f233d52) to head (6322bf8).
Report is 542 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
+ Coverage   53.35%   56.11%   +2.75%     
==========================================
  Files         480      447      -33     
  Lines       72597    66712    -5885     
==========================================
- Hits        38735    37435    -1300     
+ Misses      30855    26362    -4493     
+ Partials     3007     2915      -92     
Flag Coverage Δ
go-1.22.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xtekgrinder
Copy link
Author

@moul pinging it up as it has been a long time it has been staled

@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 8, 2024
@Kouteki Kouteki mentioned this pull request Oct 17, 2024
2 tasks
@thehowl
Copy link
Member

thehowl commented Oct 17, 2024

Hey @0xtekgrinder, apologies for the long delay, as usual.

I've taken a look at the PR; aside from being in a third-party non established repo (if you have to do actions: I'd prefer if we centralize them in this repository so we can tweak them at will), I think we want to go longer term for something different.

I'll be commenting now also on #1466. Apologies for the long wait and for the late reject.

@thehowl thehowl closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants