Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): playground section homepage #1641

Conversation

alexiscolin
Copy link
Member

Adding Gno Playground section into gno.land homepage website.

@alexiscolin alexiscolin changed the title Chore/playground section homepage chore: playground section homepage Feb 8, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 8, 2024
@alexiscolin alexiscolin changed the title chore: playground section homepage chore(examples): playground section homepage Feb 8, 2024
@alexiscolin alexiscolin mentioned this pull request Feb 8, 2024
7 tasks
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59d8787) 56.57% compared to head (3de266f) 56.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
- Coverage   56.57%   56.17%   -0.41%     
==========================================
  Files         439      439              
  Lines       66618    66242     -376     
==========================================
- Hits        37688    37209     -479     
- Misses      26013    26143     +130     
+ Partials     2917     2890      -27     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -143,6 +144,15 @@ func socialLinks() ui.Element {
}
}

func playgroundSection() ui.Element {
return ui.Element{
ui.H3("Gno Playground, a DevX tool to write and deploy smart contracts directly on Gno.land"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very long.

What about:

### Gno Playground

> a DevX tool to write and deploy smart contracts directly on Gno.land

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ccomben I tend to agree with @thehowl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title would be easier to read and the page less heavy, so more pleasant to scroll.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salmad3 any suggestions to make this title shorter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "Create, deploy, and share smart contracts."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is (visually) better in your opinion?

Build, Deploy, and Share Smart Contracts with Playground


or:

Gno Playground

Build, Deploy, and Share Smart Contracts


This is bikeshedding at this point, so I don't care whatever we do, but I'm personally of the opinion that a header should be to the point and not screw me around with productspeech. Especially since we don't have visual tools to put emphasis on "Playground" in the title.

Whichever is fine, though. So long as the line doesn't literally wrap around.

@salmad3
Copy link
Member

salmad3 commented Feb 29, 2024

Hey folks, any blockers for this (aside from updating the header element)?

@@ -143,6 +144,15 @@ func socialLinks() ui.Element {
}
}

func playgroundSection() ui.Element {
return ui.Element{
ui.H3("Gno Playground, a DevX tool to write and deploy smart contracts directly on Gno.land"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexiscolin can we update it as "Build, Deploy, and Share Smart Contracts with Playground" and resolve this comment?

@thehowl
Copy link
Member

thehowl commented Mar 4, 2024

Hey folks, any blockers for this (aside from updating the header element)?

We're good after fixing that up

@ccomben
Copy link

ccomben commented Mar 5, 2024

Hi @ilgooz @thehowl I have a lot of website updates ready for gnoland. The blocker was the portal loop not being ready, then prioritizing other company initiatives. I am meeting with @leohhhn today so will update you. Alexis is OOO this week.

@leohhhn
Copy link
Contributor

leohhhn commented Mar 6, 2024

This PR is shadowed by #1741, for the sake of urgency (we don't want to bother @alexiscolin while he is on his OOO :D)

@leohhhn leohhhn closed this Mar 6, 2024
leohhhn added a commit that referenced this pull request Mar 6, 2024
…ge (#1741)

## Description

As the title says, on request by @ilgooz & marketing. Shadows
#1641.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants