Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links into navbar #1627

Merged
merged 3 commits into from
Feb 6, 2024
Merged

docs: add links into navbar #1627

merged 3 commits into from
Feb 6, 2024

Conversation

alexiscolin
Copy link
Member

This PR aims to add following links into the docs website navbar: Playground, blog and Gno.Land homepage.

I chose to avoid setting GnoLand label as home in order to avoid a misunderstanding between docs home and Gno.Land home. But we can discuss more about the label and its position here.

Close: #1527

@alexiscolin alexiscolin requested a review from a team as a code owner February 2, 2024 15:20
@alexiscolin alexiscolin self-assigned this Feb 2, 2024
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, @waymobetta do you want this here or on https://github.com/gnolang/docs.gno.land ?

@leohhhn
Copy link
Contributor

leohhhn commented Feb 2, 2024

Would be great to see these changes without having to run locally. @albttx, can we set up deployment for PRs in case they handle docs, to have a preview?

@thehowl
Copy link
Member

thehowl commented Feb 2, 2024

Would be great to see these changes without having to run locally. @albttx, can we set up deployment for PRs in case they handle docs, to have a preview?

Since the most interesting previews are going to be the visual ones like this one anyway, I suggest you start doing this after migrating to https://github.com/gnolang/docs.gno.land so that config can also be more straightforward. :)

@alexiscolin alexiscolin added the 📖 documentation Improvements or additions to documentation label Feb 4, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Feb 5, 2024

Thanks @alexiscolin!

It seems to me that the "Back to Gno.land" text is of a diferent styling than the other text - can we make it the same for consistency? Also, clicking it opens up a new tab for Gno.land, instead of just using the current one - was this on purpose?

@albttx
Copy link
Member

albttx commented Feb 5, 2024

@alexiscolin can you move you PR to this repo please : https://github.com/gnolang/docs.gno.land

@leohhhn Yes i'll work on this once https://github.com/gnolang/docs.gno.land/pull/3/files merged

@albttx
Copy link
Member

albttx commented Feb 5, 2024

@thehowl should we close this ?

@github-actions github-actions bot removed the 📖 documentation Improvements or additions to documentation label Feb 5, 2024
@alexiscolin
Copy link
Member Author

alexiscolin commented Feb 5, 2024

@albttx OK so do we agree this repo will not handle the docs shell anymore but only the content? Because it's not up to date yet and we need to sync on this to be sure all future PR will go there

@zivkovicmilos zivkovicmilos merged commit 846956f into gnolang:master Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

docs: Add items to navbar
5 participants