Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix dependabot mod tidy #1551

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Jan 18, 2024

Description

This PR aims to fix failing Dependabot mod tidy workflows, since Dependabot doesn't have push permissions on the repo.

Error that's looking to be fixed:
Screenshot 2024-01-18 at 15 19 20

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos self-assigned this Jan 18, 2024
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner January 18, 2024 14:17
@thehowl
Copy link
Member

thehowl commented Jan 18, 2024

feel free to merge and give it a spin :)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (851a1ae) 55.91% compared to head (b9b89aa) 56.13%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
+ Coverage   55.91%   56.13%   +0.22%     
==========================================
  Files         431      431              
  Lines       65680    66053     +373     
==========================================
+ Hits        36722    37081     +359     
+ Misses      26080    26073       -7     
- Partials     2878     2899      +21     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zivkovicmilos zivkovicmilos merged commit 7aa81d1 into gnolang:master Jan 18, 2024
184 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/dependabot-tidy branch January 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants