Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load config defaults if not specified in existing config #1544

Merged
merged 10 commits into from
Jan 23, 2024

Add TOML comment test

33a1a2f
Select commit
Loading
Failed to load commit list.
Merged

fix: load config defaults if not specified in existing config #1544

Add TOML comment test
33a1a2f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 23, 2024 in 1s

1.88% of diff hit (within 100.00% threshold of 55.95%)

View this Pull Request on Codecov

1.88% of diff hit (within 100.00% threshold of 55.95%)

Annotations

Check warning on line 62 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L51-L62

Added lines #L51 - L62 were not covered by tests

Check warning on line 68 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L67-L68

Added lines #L67 - L68 were not covered by tests

Check warning on line 74 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L73-L74

Added lines #L73 - L74 were not covered by tests

Check warning on line 82 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L78-L82

Added lines #L78 - L82 were not covered by tests

Check warning on line 85 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L85

Added line #L85 was not covered by tests

Check warning on line 93 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L88-L93

Added lines #L88 - L93 were not covered by tests

Check warning on line 98 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L96-L98

Added lines #L96 - L98 were not covered by tests

Check warning on line 102 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L101-L102

Added lines #L101 - L102 were not covered by tests

Check warning on line 111 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L111

Added line #L111 was not covered by tests

Check warning on line 127 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L127

Added line #L127 was not covered by tests

Check warning on line 132 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L132

Added line #L132 was not covered by tests

Check warning on line 134 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L134

Added line #L134 was not covered by tests

Check warning on line 136 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L136

Added line #L136 was not covered by tests

Check warning on line 140 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L140

Added line #L140 was not covered by tests

Check warning on line 144 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L144

Added line #L144 was not covered by tests

Check warning on line 147 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L147

Added line #L147 was not covered by tests

Check warning on line 294 in tm2/pkg/bft/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/config.go#L294

Added line #L294 was not covered by tests

Check warning on line 46 in tm2/pkg/bft/config/toml.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/toml.go#L41-L46

Added lines #L41 - L46 were not covered by tests

Check warning on line 49 in tm2/pkg/bft/config/toml.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/toml.go#L48-L49

Added lines #L48 - L49 were not covered by tests

Check warning on line 52 in tm2/pkg/bft/config/toml.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/config/toml.go#L52

Added line #L52 was not covered by tests

Check warning on line 28 in tm2/pkg/bft/state/eventstore/types/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tm2/pkg/bft/state/eventstore/types/config.go#L28

Added line #L28 was not covered by tests