WIP fix: handle assignments to dereferenced pointer values

gno.land/cmd/gnoland/testdata/unexpected-unreal.txtar

@@ -0,0 +1,75 @@
+# Reproducible Test for https://github.com/gnolang/gno/issues/1167
+
+gnoland start
+
+# add contract
+gnokey maketx addpkg -pkgdir $WORK -pkgpath gno.land/r/demo/xx -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+# execute New
+gnokey maketx call -pkgpath gno.land/r/demo/xx -func New -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+# execute Delta for the first time
+gnokey maketx call -pkgpath gno.land/r/demo/xx -func Delta -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+-- gno.mod --
+module gno.land/r/demo/xx
+
+require (
+	gno.land/p/demo/avl v0.0.0-latest
+)
+
+-- realm.gno --
+package xx
+
+import (
+	"strconv"
+
+	"gno.land/p/demo/avl"
+)
+
+type Move struct {
+	N1, N2, N3 byte
+}
+
+type S struct {
+	Moves []Move
+}
+
+func (s S) clone() S {
+	mv := s.Moves
+	return S{Moves: mv}
+}
+
+func (olds S) change() S {
+	s := olds.clone()
+
+	counter++
+	s.Moves = append([]Move{}, s.Moves...)
+	s.Moves = append(s.Moves, Move{counter, counter, counter})
+	return s
+}
+
+var el *S
+var counter byte
+
+func New() {
+	el = &S{}
+}
+
+func Delta() string {
+	n := el.change()
+	*el = n
+	return Values()
+}
+
+func Values() string {
+	s := ""
+	for _, val := range el.Moves {
+		s += strconv.Itoa(int(val.N1)) + "," + strconv.Itoa(int(val.N2)) + "," + strconv.Itoa(int(val.N3)) + ";"
+	}
+	return s
+}
+

gnovm/pkg/gnolang/op_call.go

@@ -165,7 +165,7 @@ func (m *Machine) doOpCall() {
 		// Make a copy so that a reference to the arguemnt isn't used
 		// in cases where the non-primitive value type is represented
 		// as a pointer, *StructValue, for example.
-		b.Values[i] = pv.Copy(m.Alloc)
+		b.Values[i] = pv.Copy(m.Alloc, m.Store)
 	}
 }
 
@@ -400,7 +400,7 @@ func (m *Machine) doOpDefer() {
 
 func (m *Machine) doOpPanic1() {
 	// Pop exception
-	var ex TypedValue = m.PopValue().Copy(m.Alloc)
+	var ex TypedValue = m.PopValue().Copy(m.Alloc, m.Store)
 	// Panic
 	m.Panic(ex)
 }

gnovm/pkg/gnolang/op_exec.go

@@ -149,7 +149,7 @@
 				*xv = *dv
 			} else {
 				dv = xv
-				*xv = xv.Copy(m.Alloc)
+				*xv = xv.Copy(m.Alloc, m.Store)
 			}
 			ll = dv.GetLength()
 			if ll == 0 { // early termination
@@ -173,7 +173,7 @@
 				case DEFINE:
 					knxp := bs.Key.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, knxp)
-					ptr.TV.Assign(m.Alloc, iv, false)
+					ptr.TV.Assign(m.Alloc, m.Store, iv, false)
 				default:
 					panic("should not happen")
 				}
@@ -188,7 +188,7 @@
 				case DEFINE:
 					vnxp := bs.Value.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, vnxp)
-					ptr.TV.Assign(m.Alloc, ev, false)
+					ptr.TV.Assign(m.Alloc, m.Store, ev, false)
 				default:
 					panic("should not happen")
 				}
@@ -269,7 +269,7 @@
 				case DEFINE:
 					knxp := bs.Key.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, knxp)
-					ptr.TV.Assign(m.Alloc, iv, false)
+					ptr.TV.Assign(m.Alloc, m.Store, iv, false)
 				default:
 					panic("should not happen")
 				}
@@ -282,7 +282,7 @@
 				case DEFINE:
 					vnxp := bs.Value.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, vnxp)
-					ptr.TV.Assign(m.Alloc, ev, false)
+					ptr.TV.Assign(m.Alloc, m.Store, ev, false)
 				default:
 					panic("should not happen")
 				}
@@ -362,7 +362,7 @@
 				case DEFINE:
 					knxp := bs.Key.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, knxp)
-					ptr.TV.Assign(m.Alloc, kv, false)
+					ptr.TV.Assign(m.Alloc, m.Store, kv, false)
 				default:
 					panic("should not happen")
 				}
@@ -375,7 +375,7 @@
 				case DEFINE:
 					vnxp := bs.Value.(*NameExpr).Path
 					ptr := m.LastBlock().GetPointerTo(m.Store, vnxp)
-					ptr.TV.Assign(m.Alloc, vv, false)
+					ptr.TV.Assign(m.Alloc, m.Store, vv, false)
 				default:
 					panic("should not happen")
 				}
@@ -885,7 +885,7 @@
 					vp := NewValuePath(
 						VPBlock, 1, 0, ss.VarName)
 					ptr := b.GetPointerTo(m.Store, vp)
-					ptr.TV.Assign(m.Alloc, *xv, false)
+					ptr.TV.Assign(m.Alloc, m.Store, *xv, false)
 				}
 				// expand block size
 				if nn := cs.GetNumNames(); int(nn) > len(b.Values) {

gnovm/pkg/gnolang/ownership.go

@@ -104,6 +104,7 @@
 	IncRefCount() int
 	DecRefCount() int
 	GetRefCount() int
+	SetRefCount(int)
 	GetIsDirty() bool
 	SetIsDirty(bool, uint64)
 	GetIsEscaped() bool
@@ -117,6 +118,8 @@
 	GetIsNewDeleted() bool
 	SetIsNewDeleted(bool)
 	GetIsTransient() bool
+	GetNextObjectID() ObjectID
+	SetNextObjectID(ObjectID)
 
 	// Saves to realm along the way if owned, and also (dirty
 	// or new).
@@ -144,6 +147,7 @@
 	isNewReal    bool
 	isNewEscaped bool
 	isNewDeleted bool
+	nextID       ObjectID // set if replacing pre-existing object.
 
 	// XXX huh?
 	owner Object // mem reference to owner.
@@ -164,6 +168,7 @@
 		isNewReal:    oi.isNewReal,
 		isNewEscaped: oi.isNewEscaped,
 		isNewDeleted: oi.isNewDeleted,
+		nextID:       oi.nextID,
 	}
 }
 
@@ -265,6 +270,10 @@
 	return oi.RefCount
 }
 
+func (oi *ObjectInfo) SetRefCount(rc int) {
+	oi.RefCount = rc
+}
+
 func (oi *ObjectInfo) GetIsDirty() bool {
 	return oi.isDirty
 }
@@ -324,6 +333,14 @@
 	return false
 }
 
+func (oi *ObjectInfo) GetNextObjectID() ObjectID {
+	return oi.nextID
+}
+
+func (oi *ObjectInfo) SetNextObjectID(nid ObjectID) {
+	oi.nextID = nid
+}
+
 func (tv *TypedValue) GetFirstObject(store Store) Object {
 	switch cv := tv.V.(type) {
 	case PointerValue:

gnovm/pkg/gnolang/realm.go

@@ -390,8 +390,21 @@
 	if !oo.GetObjectID().IsZero() {
 		return
 	}
-	rlm.assignNewObjectID(oo)
-	rlm.created = append(rlm.created, oo)
+	noid := oo.GetNextObjectID()
+	if !noid.IsZero() {
+		// consume NextObjectID.
+		oo.SetObjectID(noid)
+		oo.SetNextObjectID(ObjectID{})
+		// rlm.created not touched, not actually.
+		// instead, is considered updated.
+		rlm.updated = append(rlm.updated, oo)
+		// however, we do need the following
+		// recurse logic to inc refcount
+		// children of this replacement object.
+	} else {
+		rlm.assignNewObjectID(oo)
+		rlm.created = append(rlm.created, oo)
+	}
 	// RECURSE GUARD END
 
 	// recurse for children.

gnovm/pkg/gnolang/uverse.go

@@ -296,8 +296,6 @@ func UverseNode() *PackageNode {
 								if argsb.Data == nil {
 									for i := 0; i < argsl; i++ {
 										oldElem := list[xvo+xvl+i]
-										// unrefCopy will resolve references and copy their values
-										// to copy by value rather than by reference.
 										newElem := argsb.List[argso+i].unrefCopy(m.Alloc, m.Store)
 										list[xvo+xvl+i] = newElem