Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Dependabot recursive go mod tidy support #1412

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR introduces a simple workflow that tidies go mod files on Dependabot PRs, and turns off the mod check for those PRs (to avoid overlapping workflows).

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 🌟 improvement performance improvements, refactors ... label Dec 5, 2023
@zivkovicmilos zivkovicmilos self-assigned this Dec 5, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner December 5, 2023 10:25
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2034b1) 55.87% compared to head (cfccc79) 55.87%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1412   +/-   ##
=======================================
  Coverage   55.87%   55.87%           
=======================================
  Files         431      431           
  Lines       65656    65656           
=======================================
  Hits        36685    36685           
  Misses      26103    26103           
  Partials     2868     2868           
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl changed the title fix: add Dependabot recursive go mod tidy support ci: add Dependabot recursive go mod tidy support Dec 7, 2023
.github/workflows/misc.yml Outdated Show resolved Hide resolved
@ajnavarro
Copy link
Contributor

Maybe that can be done using dependabot groups

@zivkovicmilos
Copy link
Member Author

Maybe that can be done using dependabot groups

I love this 💯

I'm gonna push a PR soon for the gno repo to add these groups, but also for our other repos (JS clients especially, this will save my sanity)

@thehowl thehowl merged commit b83f86b into gnolang:master Dec 21, 2023
179 of 181 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/dependabot-mod-tidy branch December 21, 2023 12:36
gfanton added a commit to moul/gno that referenced this pull request Jan 18, 2024
## Description

This PR introduces a simple workflow that tidies go mod files on
Dependabot PRs, and turns off the mod check for those PRs (to avoid
overlapping workflows).

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Guilhem Fanton <[email protected]>
Co-authored-by: Manfred Touron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 improvement performance improvements, refactors ...
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants