Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement r/demo/postit #1396

Closed
wants to merge 37 commits into from
Closed

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Nov 28, 2023

Very Basic Twitter Clone

Frontend: https://postitsocial.netlify.app/

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@harry-hov harry-hov self-assigned this Nov 28, 2023
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.29%. Comparing base (4749369) to head (b6c8dd0).
Report is 229 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   47.98%   47.29%   -0.70%     
==========================================
  Files         372      391      +19     
  Lines       63091    63067      -24     
==========================================
- Hits        30277    29827     -450     
- Misses      30352    30761     +409     
- Partials     2462     2479      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,188 @@
package postit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a comment stating this file is temporary, pending JSON support implementation.

}

func getUserRefByUsername(username string) *User {
res, ok := users.Get(username)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to be compatible with r/users; or maybe having r/users to be the way to get “verified” while having a built in light alternative?


func UpdateBio(bio string) string {
// TODO: add checks
caller := std.PrevRealm().Addr()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something i started to work on with a r/profile (#181) realm.

Could worth switching when ready, to have unified bio across the whole contract ecosystem.

@@ -0,0 +1,188 @@
package postit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a Render() func too, could just give some basic info and suggest to use the better frontend.

@thehowl
Copy link
Member

thehowl commented Oct 2, 2024

Unlikely to be continued; if someone wants to continue it please open a separate PR continuing Hariom's work.

@thehowl thehowl closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: 🔵 Not Needed for Launch
Development

Successfully merging this pull request may close these issues.

3 participants