-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: In TestGnoDoc, fix expected output for "doc", "avl" #1301
Conversation
Signed-off-by: Jeff Thompson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 372 372
Lines 62990 62990
=======================================
Hits 30177 30177
- Misses 30352 30354 +2
+ Partials 2461 2459 -2 ☔ View full report in Codecov by Sentry. |
Yes, you're right. The issue is that I've made a note to fix the root issue; in the meantime I'll merge this so that Thanks! |
In the root folder, `make test` has one failure: `FAIL: TestGnoDoc/doc_avl (0.01s)` . This is a failure of [this test](https://github.com/gnolang/gno/blob/eb421578ec72d70d2cbd930576856623376f2daa/gnovm/cmd/gno/doc_test.go#L12-L13) which expects "func NewNode". However in folder gnovm/cmd/gno, `go run . doc avl` prints: ``` package avl // import "gno.land/p/demo/avl" type MutTree struct{ ... } func NewMutTree() *MutTree type Tree struct{ ... } func NewTree(key string, value interface{}) *Tree ``` Therefore, this PR changes the test to expect "func NewTree". With this fix, `make test` passes. (Of course, maybe `go run . doc avl` really should have "func NewNode". But I'm assuming that there was an update after the test was written.) Signed-off-by: Jeff Thompson <[email protected]>
In the root folder, `make test` has one failure: `FAIL: TestGnoDoc/doc_avl (0.01s)` . This is a failure of [this test](https://github.com/gnolang/gno/blob/eb421578ec72d70d2cbd930576856623376f2daa/gnovm/cmd/gno/doc_test.go#L12-L13) which expects "func NewNode". However in folder gnovm/cmd/gno, `go run . doc avl` prints: ``` package avl // import "gno.land/p/demo/avl" type MutTree struct{ ... } func NewMutTree() *MutTree type Tree struct{ ... } func NewTree(key string, value interface{}) *Tree ``` Therefore, this PR changes the test to expect "func NewTree". With this fix, `make test` passes. (Of course, maybe `go run . doc avl` really should have "func NewNode". But I'm assuming that there was an update after the test was written.) Signed-off-by: Jeff Thompson <[email protected]>
In the root folder,
make test
has one failure:FAIL: TestGnoDoc/doc_avl (0.01s)
. This is a failure of this test which expects "func NewNode". However in folder gnovm/cmd/gno,go run . doc avl
prints:Therefore, this PR changes the test to expect "func NewTree". With this fix,
make test
passes.(Of course, maybe
go run . doc avl
really should have "func NewNode". But I'm assuming that there was an update after the test was written.)