fix(gnolang): allow floats in inc/dec statements #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
+ Coverage 55.62% 55.94% +0.31%
==========================================
Files 420 420
Lines 65441 65477 +36
==========================================
+ Hits 36400 36629 +229
+ Misses 26188 25983 -205
- Partials 2853 2865 +12 ☔ View full report in Codecov by Sentry. |
ajnavarro
approved these changes
Oct 11, 2023
moul
approved these changes
Oct 11, 2023
3 tasks
|
ping @thehowl for merging. |
|
@ajnavarro blocked awaiting @piux2 / @jaekwon review. |
zivkovicmilos
approved these changes
Nov 9, 2023
|
Merging per discussion with Ray. (Given Jae has not given feedback yet, we can merge this PR in order to unblock other work.) His concerns regarding the fact that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1151 (split from #1153)