Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: teritori contracts #1154

Closed
wants to merge 66 commits into from
Closed

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Sep 18, 2023

This is a snapshot of the contracts developed by the Teritori team

See the overview for more information

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@n0izn0iz n0izn0iz requested review from jaekwon, moul and a team as code owners September 18, 2023 21:29
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Sep 18, 2023
@n0izn0iz n0izn0iz changed the title Teritori unified Teritori contracts Sep 18, 2023
@n0izn0iz n0izn0iz marked this pull request as draft September 18, 2023 21:48
@n0izn0iz n0izn0iz force-pushed the teritori-unified branch 3 times, most recently from bb9753f to aca197f Compare September 19, 2023 00:32
@n0izn0iz n0izn0iz changed the title Teritori contracts feat: teritori contracts Sep 19, 2023
@github-actions github-actions bot removed the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 19, 2023
@n0izn0iz n0izn0iz force-pushed the teritori-unified branch 3 times, most recently from a4dfe43 to d088ec6 Compare September 20, 2023 14:44
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (1a19359) to head (7a7a949).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
- Coverage   47.44%   44.67%   -2.77%     
==========================================
  Files         384      433      +49     
  Lines       61220    65960    +4740     
==========================================
+ Hits        29045    29467     +422     
- Misses      29745    34054    +4309     
- Partials     2430     2439       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n0izn0iz n0izn0iz marked this pull request as ready for review September 27, 2023 15:03
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for completing these milestones 🙏

I have left some comments, mostly just questions and pointers to leftover code segments.

Calling @gfanton and @ajnavarro to also take a look through the code.

What you can't see from this codebase is how this integrates with Teritori, @n0izn0iz are there any Looms / recordings of these contracts in action on the Teritori app? We did showcases live on calls, but I would love the rest of the team to see them as well.

Amazing work 👏

Comment on lines +1 to +2
gnokey maketx call \
-pkgpath "gno.land/r/demo/social_feeds" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about converting this to a shell script file, like with other examples?

@ajnavarro
Copy link
Contributor

Thank you for completing these milestones 🙏

I have left some comments, mostly just questions and pointers to leftover code segments.

Calling @gfanton and @ajnavarro to also take a look through the code.

What you can't see from this codebase is how this integrates with Teritori, @n0izn0iz are there any Looms / recordings of these contracts in action on the Teritori app? We did showcases live on calls, but I would love the rest of the team to see them as well.

Amazing work 👏

@zivkovicmilos anything specific to check? Reviewing 14k lines and more than 150 files changed will take a good amount of time.

Copy link
Member

@gfanton gfanton Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this to gnovm/stdlibs/unicode/utf16, along with theirs respective tests.
And update compatibility file on the way

Signed-off-by: Norman Meier <[email protected]>
n0izn0iz and others added 26 commits April 10, 2024 19:15
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
need to open an issue, PrevRealm was defined here before

Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz
Copy link
Contributor Author

Closing to atomicize

@n0izn0iz n0izn0iz closed this Apr 11, 2024
@n0izn0iz n0izn0iz mentioned this pull request Apr 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: 🌟 Wanted for Launch
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants