-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: teritori contracts #1154
feat: teritori contracts #1154
Conversation
bb9753f
to
aca197f
Compare
a4dfe43
to
d088ec6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
- Coverage 47.44% 44.67% -2.77%
==========================================
Files 384 433 +49
Lines 61220 65960 +4740
==========================================
+ Hits 29045 29467 +422
- Misses 29745 34054 +4309
- Partials 2430 2439 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for completing these milestones 🙏
I have left some comments, mostly just questions and pointers to leftover code segments.
Calling @gfanton and @ajnavarro to also take a look through the code.
What you can't see from this codebase is how this integrates with Teritori, @n0izn0iz are there any Looms / recordings of these contracts in action on the Teritori app? We did showcases live on calls, but I would love the rest of the team to see them as well.
Amazing work 👏
gnokey maketx call \ | ||
-pkgpath "gno.land/r/demo/social_feeds" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about converting this to a shell script file, like with other examples?
examples/gno.land/p/demo/teritori/dao_proposal_single/update_settings.gno
Show resolved
Hide resolved
@zivkovicmilos anything specific to check? Reviewing 14k lines and more than 150 files changed will take a good amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to gnovm/stdlibs/unicode/utf16
, along with theirs respective tests.
And update compatibility file on the way
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
need to open an issue, PrevRealm was defined here before Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
4470e0e
to
dc1474c
Compare
Closing to atomicize |
This is a snapshot of the contracts developed by the Teritori team
See the overview for more information
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description