Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(gnovm): Incorrect pointer comparison #2624

Closed
deelawn opened this issue Jul 23, 2024 · 0 comments · Fixed by #2627
Closed

bug(gnovm): Incorrect pointer comparison #2624

deelawn opened this issue Jul 23, 2024 · 0 comments · Fixed by #2627
Assignees
@petar-dambovaliev

Comments

@deelawn
Copy link
Contributor

deelawn commented Jul 23, 2024

Incorrect pointer comparison

Description

When comparing two interfaces with underlying pointer types, they should only evaluate to true if both the types and the values are equal. In gno, the comparison seems not to consider the pointer type and evaluates to true as long as the "address" is the same.

In go: https://goplay.tools/snippet/zgyu54FGKk6
In gno: https://play.gno.land/p/QmBygigR1_h
@deelawn deelawn mentioned this issue Jul 23, 2024
Open
7 tasks
@petar-dambovaliev petar-dambovaliev self-assigned this Jul 24, 2024
@petar-dambovaliev petar-dambovaliev mentioned this issue Jul 24, 2024
Merged
thehowl pushed a commit that referenced this issue Jul 29, 2024
@petar-dambovaliev @deelawn
fix(gnovm): equality on interfaces of underlying pointer types (#2627)
137d174 
fixes [this](#2624)

When comparing 2 upcasted pointers, if the types are not the same, they
are not equal.

---------

Co-authored-by: deelawn <[email protected]>
@Kouteki Kouteki mentioned this issue Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petar-dambovaliev petar-dambovaliev

Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pointer eq gnolang/gno
2 participants
@deelawn @petar-dambovaliev