Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ops] Add release flow for gnofaucet #2557

Closed
zivkovicmilos opened this issue Jul 9, 2024 · 0 comments · Fixed by #2672
Closed

[ops] Add release flow for gnofaucet #2557

zivkovicmilos opened this issue Jul 9, 2024 · 0 comments · Fixed by #2672
Assignees
@sw360cab
Labels
🐞 bug Something isn't working

Comments

@zivkovicmilos
Copy link
Member

Description

The gnofaucet tool's releases have been stopped 2 months ago when we introduced Goreleaser #2101.

Currently, the version of gnofaucet is oudated, but still working with master.

We should implement a master release flow for gnofaucet
@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Jul 9, 2024
@thehowl thehowl mentioned this issue Jul 9, 2024
Closed
@sw360cab sw360cab mentioned this issue Aug 9, 2024
Merged
7 tasks
sw360cab added a commit that referenced this issue Aug 12, 2024
@sw360cab
ci: Full revision of Goreleaser tasks (#2672)
ff0c177 
This PR has different purposes:
* adding Gnofaucet to Goreleaser task (closes #2557)
* moving Goreleaser from v 1.26 to v 2.1
* reducing the verbosity of tasks by merging the different release types
(latest, nightly, master) into a single goreleaser file
* adding a fallbacked env variable called `TAG_VERSION`, which label the
various docker images
  * adding the `nightly` subtask, which is ignored for latest releases
* skipping publish for master release (NOTE: this part is the one TBC,
because `master` release is using nightly too, but the variable
`tag_name` unfortunately cannot be templated, let's see if it can make
sense or if there is another workaround)

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
MikaelVallenet pushed a commit to MikaelVallenet/gno that referenced this issue Aug 17, 2024
@sw360cab @MikaelVallenet
ci: Full revision of Goreleaser tasks (gnolang#2672)
b428353 
This PR has different purposes:
* adding Gnofaucet to Goreleaser task (closes gnolang#2557)
* moving Goreleaser from v 1.26 to v 2.1
* reducing the verbosity of tasks by merging the different release types
(latest, nightly, master) into a single goreleaser file
* adding a fallbacked env variable called `TAG_VERSION`, which label the
various docker images
  * adding the `nightly` subtask, which is ignored for latest releases
* skipping publish for master release (NOTE: this part is the one TBC,
because `master` release is using nightly too, but the variable
`tag_name` unfortunately cannot be templated, let's see if it can make
sense or if there is another workaround)

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
linhpn99 pushed a commit to linhpn99/gno that referenced this issue Aug 20, 2024
@sw360cab @linhpn99
ci: Full revision of Goreleaser tasks (gnolang#2672)
8c6332c 
This PR has different purposes:
* adding Gnofaucet to Goreleaser task (closes gnolang#2557)
* moving Goreleaser from v 1.26 to v 2.1
* reducing the verbosity of tasks by merging the different release types
(latest, nightly, master) into a single goreleaser file
* adding a fallbacked env variable called `TAG_VERSION`, which label the
various docker images
  * adding the `nightly` subtask, which is ignored for latest releases
* skipping publish for master release (NOTE: this part is the one TBC,
because `master` release is using nightly too, but the variable
`tag_name` unfortunately cannot be templated, let's see if it can make
sense or if there is another workaround)

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sw360cab sw360cab

Labels
🐞 bug Something isn't working
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Full revision of Goreleaser tasks sw360cab/gno
2 participants
@sw360cab @zivkovicmilos