Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uassert/urequire: Wrong message when strings are not the same. #2502

Closed
ajnavarro opened this issue Jul 4, 2024 · 1 comment · Fixed by #2507
Closed

uassert/urequire: Wrong message when strings are not the same. #2502

ajnavarro opened this issue Jul 4, 2024 · 1 comment · Fixed by #2507
Labels
🐞 bug Something isn't working 🧾 package/realm Tag used for new Realms or Packages.

Comments

@ajnavarro
Copy link
Contributor

[Subject of the issue]

Description

When using uassert.Equal or urequire.Equal with strings and they are not the same, the provided error message is wrong.

Your environment

Steps to reproduce

  • Tell us how to reproduce this issue
  • Where the issue is, if you know
  • Which commands triggered the issue, if any

Expected behavior

uassert.Equal: same type but different value
        expected: No proposals found :(.
        actual:  OBTAINED STRING

Actual behavior

uassert.Equal: same type but different value
        expected: No proposals found :(.
        actual:   unsupported type

Logs

Proposed solution
@ajnavarro ajnavarro added 🐞 bug Something isn't working 🧾 package/realm Tag used for new Realms or Packages. labels Jul 4, 2024
@linhpn99 linhpn99 mentioned this issue Jul 4, 2024
Merged
7 tasks
@linhpn99
Copy link
Contributor

linhpn99 commented Jul 4, 2024

Here is the hotfix PR #2507

@zivkovicmilos zivkovicmilos linked a pull request Jul 5, 2024 that will close this issue
fix(examples): fix output of uassert.Equal() #2507
Merged
7 tasks
zivkovicmilos pushed a commit that referenced this issue Jul 5, 2024
@linhpn99
fix(examples): fix output of uassert.Equal() (#2507)
ee69fbd 
Related to #2502

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
gfanton pushed a commit to gfanton/gno that referenced this issue Jul 23, 2024
@linhpn99 @gfanton
fix(examples): fix output of uassert.Equal() (gnolang#2507)
4c364a9 
Related to gnolang#2502

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 🧾 package/realm Tag used for new Realms or Packages.
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(examples): fix output of uassert.Equal() linhpn99/gno
2 participants
@ajnavarro @linhpn99