Incorporating gno test into gnovm's Coverage Metrics #1145
Comments
moul
changed the title
gnodev test into account
|
(temporarily) assign @gfanton, since he's working on a related project. Feel free to unassign. |
|
Please be aware that we currently have two distinct gaps in our testing related to .gno files:
CLI should look like this: |
|
Related with #1215. |
thehowl
changed the title
Kouteki
modified the milestones:
🌟 main.gno.land (wanted),
🏗4️⃣ test4.gno.land [POST LAUNCH]
1 task
thehowl
pushed a commit
that referenced
this issue
May 30, 2024
No new tests have been added yet, but existing tests in gnovm/tests/files are now executed in the context of the package which contains the relevant interpreter virtual machine and parser code. We have now a better baseline to measure and complete the code coverage. This represents more than 800 tests, which takes 10s on my macbook air m1. Those tests are actually run twice, as I haven't yet removed the original execution from gnovm/tests. The testing code is substantially simplified compared to its counterpart in gnovm/tests, but has not yet been deduplicated. This will be done in further commits. In `gnovm/pkg/golang`, `go test -cover` went from 34.2% to 66.7%. Related to #1121, #1145 and probably more <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [*] Added new tests, or not needed, or not feasible - [*] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [*] Updated the official documentation or not needed - [*] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [*] Added references to related issues and PRs - [*] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]>
omarsy
pushed a commit
to TERITORI/gno
that referenced
this issue
Jun 3, 2024
No new tests have been added yet, but existing tests in gnovm/tests/files are now executed in the context of the package which contains the relevant interpreter virtual machine and parser code. We have now a better baseline to measure and complete the code coverage. This represents more than 800 tests, which takes 10s on my macbook air m1. Those tests are actually run twice, as I haven't yet removed the original execution from gnovm/tests. The testing code is substantially simplified compared to its counterpart in gnovm/tests, but has not yet been deduplicated. This will be done in further commits. In `gnovm/pkg/golang`, `go test -cover` went from 34.2% to 66.7%. Related to gnolang#1121, gnolang#1145 and probably more <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [*] Added new tests, or not needed, or not feasible - [*] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [*] Updated the official documentation or not needed - [*] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [*] Added references to related issues and PRs - [*] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]>
zivkovicmilos
added
the
help wanted
|
Related with #2616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To enhance our coverage, we might consider writing a unit test that imports
gnovm/cmd/gnoand invokes themain()function using customos.Args, rather than executing the generated binary. By adopting this approach, we can ensure comprehensive code coverage for all elements we test with.gnofiles on the filesystem.Recent example: https://github.com/gnolang/gno/pull/1143/files#diff-0db317cbf7340addf668ab0f07d8daca6817b2e05b567f37a37e5c76ab6b3232R182
Related with #1139
Related with #1117 (similar approach)
The text was updated successfully, but these errors were encountered: